Skip to content

Manchester | 26-ITP-May | Abdu Hassen | Sprint 1 | Form Controls#1344

Open
Abduhasen wants to merge 1 commit into
CodeYourFuture:mainfrom
Abduhasen:form-controls
Open

Manchester | 26-ITP-May | Abdu Hassen | Sprint 1 | Form Controls#1344
Abduhasen wants to merge 1 commit into
CodeYourFuture:mainfrom
Abduhasen:form-controls

Conversation

@Abduhasen
Copy link
Copy Markdown

…elect for size choose,radio also for colour choose, used a lot
for spacing.

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

wrote a form control that takes first name, last name, email, colour and also size of a t-shirt i wrote form control using html

Questions

N/A

…elect for size choose,radio also for colour choose, used a lot <br> for spacing.
@netlify
Copy link
Copy Markdown

netlify Bot commented May 23, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 754a036
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a11eb6dd4081e000885cf81
😎 Deploy Preview https://deploy-preview-1344--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@Abduhasen Abduhasen added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels May 23, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 23, 2026
@Abduhasen Abduhasen added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 23, 2026
Copy link
Copy Markdown

@Luro91 Luro91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can you achieve a lighthouse score of 100?

Image

Comment thread Form-Controls/index.html
id="fname"
maxlength="10"
minlength="2"
pattern="[A-Za-z]+"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not allow special characters like the German ä,ü,ö

@Luro91 Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Onboarding The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants